#11 gcc 4.3 build issues - Imprudence Viewer

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#11 ✓done

gcc 4.3 build issues

Reported by Stephen Zenith | November 30th, 2008 @ 04:53 PM | in 1.0.0 RC2

Imprudence fails to build on a system with gcc 4.3. Most of the issues are to do with the compiler detecting the following as unsafe:

printf (someNonLiteralString);

The fix is to replace it with something along the lines of:

printf ("%s", someNonLiteralString);

Note that this doesn't affect this, as the compiler knows the string literal is safe:

printf ("A literal string");

The attached patch fixes the affected lines, and also fixes the "typedef struct Vertex" issue that is already fixed in the OpenAL branch. I've tested that it applies cleanly to a fresh download of the 1.0.0RC1 source.

gcc-43-fix.patch 3.29 KB

Comments and changes to this ticket

You flagged this item as spam.
Stephen Zenith November 30th, 2008 @ 04:54 PM
- Assigned user cleared.
Jacek Antonelli November 30th, 2008 @ 09:12 PM
- Tag set to “bug, compile”
- Milestone set to “1.0.0 RC2”
- State changed from “new” to “done”
- Assigned user set to “Jacek Antonelli”
Patch applied to the 'next' branch. This should ship with RC2. Thanks!

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.