Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Bad string compare

#22

newview/llviewernetwork.cpp, make a compariosn to a static string. This gives a warning in a newer gcc version. Should use strcmp instead, this patch is not verified yet.


diff --git a/linden/indra/newview/llviewernetwork.cpp b/linden/indra/newview/llv
index c8cffcf..e41db3d 100644
--- a/linden/indra/newview/llviewernetwork.cpp
+++ b/linden/indra/newview/llviewernetwork.cpp
@@ -163,7 +163,7 @@ std::string LLViewerLogin::getGridLabel() const

 std::string LLViewerLogin::getGridCodeName() const
 {
-       if( gGridInfo[mGridChoice].mCodeName == "" )
+       if(! strcmp(gGridInfo[mGridChoice].mCodeName, "" ))
        {
                return getGridLabel();
        }

Reported by balp · December 8th, 2008 @ 02:56 PM

State: done
Milestone: 1.0.0 Release
Assigned to: Jacek Antonelli Jacek Antonelli

Activity

  1. balp
    balp

    gcc (GCC) 4.2.4 (Ubuntu 4.2.4-1ubuntu3)

    December 8th, 2008 @ 02:59 PM

  2. Jacek Antonelli
    Jacek Antonelli
    • Assigned user set to Jacek Antonelli
    • State changed from new to open
    • Milestone set to 1.0.0 Release

    December 10th, 2008 @ 02:06 AM

  3. Jacek Antonelli
    Jacek Antonelli
    • Tag set to bug
    • State changed from open to done

    Mea culpa. Thanks for the report, balp! It will roll out in the 1.0.0 release.

    December 11th, 2008 @ 04:40 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.