#22 ✓done
balp

Bad string compare

Reported by balp | December 8th, 2008 @ 02:56 PM | in 1.0.0 Release

newview/llviewernetwork.cpp, make a compariosn to a static string. This gives a warning in a newer gcc version. Should use strcmp instead, this patch is not verified yet.


diff --git a/linden/indra/newview/llviewernetwork.cpp b/linden/indra/newview/llv
index c8cffcf..e41db3d 100644
--- a/linden/indra/newview/llviewernetwork.cpp
+++ b/linden/indra/newview/llviewernetwork.cpp
@@ -163,7 +163,7 @@ std::string LLViewerLogin::getGridLabel() const

 std::string LLViewerLogin::getGridCodeName() const
 {
-       if( gGridInfo[mGridChoice].mCodeName == "" )
+       if(! strcmp(gGridInfo[mGridChoice].mCodeName, "" ))
        {
                return getGridLabel();
        }

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Open source metaverse (Second Life) viewer with an emphasis on usability and bold changes.

Shared Ticket Bins

People watching this ticket

Tags

Pages